Disable test_asymmetric_dma_transfer for S3 #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
force-pushed
the
feat/disable-failing-test
branch
from
2d8a2d4 to
e73f11b
Compare
jessebraham
approved these changes
Jul 31, 2024
|
Just added |
|
I2S is now failing for the S3 in HIL. Don't think we're ready to make this a required check yet. |
Thanks for disabling it again, Ill have a look tomorrow to see what is failing |
|
Just tried locally, and I was able to reproduce the transient failures on the I2S test for S3, might be related to the DMA issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Disables the failing test for S3, so we get the workflow back to green and we can reenable the required check.
Testing
https://github.com/esp-rs/esp-hal/actions/runs/10182650638